gyfora commented on code in PR #941:
URL: 
https://github.com/apache/flink-kubernetes-operator/pull/941#discussion_r1943177167


##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/utils/FlinkUtils.java:
##########
@@ -403,6 +403,28 @@ public static Long 
calculateClusterMemoryUsage(Configuration conf, int taskManag
         return tmTotalMemory + jmTotalMemory;
     }
 
+    public static Long calculateClusterStateSize(Configuration conf, int 
taskManagerReplicas) {

Review Comment:
   Ok but I still don't get 3 things:
    - Where is this used?
    - Why do we need this bad approximation if state size metrics are available 
from Flink?
    - This is basically just total memory, why do we call it state size?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to