davidradl commented on code in PR #26111:
URL: https://github.com/apache/flink/pull/26111#discussion_r1943263854


##########
flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DispatcherTest.java:
##########
@@ -1225,7 +1257,16 @@ public void testOverridingJobVertexParallelisms() throws 
Exception {
 
     private JobManagerRunner runningJobManagerRunnerWithJobStatus(
             final JobStatus currentJobStatus) {
+        return runningJobManagerRunnerWithJobStatus(currentJobStatus, jobId, 
0L);
+    }
+
+    private JobManagerRunner runningJobManagerRunnerWithJobStatus(
+            final JobStatus currentJobStatus, final JobID jobId, long 
startTime) {
         Preconditions.checkArgument(!currentJobStatus.isTerminalState());
+        long[] stateTimeStampsForRunningJob = new 
long[JobStatus.values().length];

Review Comment:
   I assume that this method ends up being called and we want the order of the 
jobs to be sensible. Would the most sensible for the UI be the latest first?    
 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to