yuxiqian commented on code in PR #3902:
URL: https://github.com/apache/flink-cdc/pull/3902#discussion_r1944038007


##########
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/source/offset/BinlogOffset.java:
##########


Review Comment:
   BinlogOffset#compareTo is a general-purposed comparison method, and this 
change might affect more than backfill necessity check. Is it possible to tweak 
`SnapshotSplitReader#isBackfillRequired` only?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to