[ 
https://issues.apache.org/jira/browse/FLINK-5188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15747908#comment-15747908
 ] 

ASF GitHub Bot commented on FLINK-5188:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3003#discussion_r92360560
  
    --- Diff: 
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/batch/table/SortITCase.scala
 ---
    @@ -58,7 +59,10 @@ class SortITCase(
         val expected = sortExpectedly(tupleDataSetStrings)
         val results = t.toDataSet[Row].mapPartition(rows => 
Seq(rows.toSeq)).collect()
     
    -    val result = results.filterNot(_.isEmpty).sortBy(p => 
p.head).reduceLeft(_ ++ _)
    +    val result = results
    +      .filterNot(_.isEmpty)
    +      .sortBy(_.head)(Ordering.by(f=> f.toString))
    --- End diff --
    
    Can we remove the implicit `Product` ordering above?


> Adjust all the imports referencing types.Row and move RowCsvInputFormat
> -----------------------------------------------------------------------
>
>                 Key: FLINK-5188
>                 URL: https://issues.apache.org/jira/browse/FLINK-5188
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Core, Table API & SQL
>            Reporter: Anton Solovev
>            Assignee: Anton Solovev
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to