Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/3001#discussion_r92366382
--- Diff:
flink-connectors/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumerTest.java
---
@@ -377,19 +378,19 @@ public void
testUnparsableLongForAggregationMaxCountInConfig() {
//
----------------------------------------------------------------------
@Test
- public void testSnapshotStateShouldBeNullIfSourceNotOpened() throws
Exception {
+ public void testSnapshotStateShouldBeEmptyListIfSourceNotOpened()
throws Exception {
Properties config = new Properties();
config.setProperty(AWSConfigConstants.AWS_REGION, "us-east-1");
config.setProperty(AWSConfigConstants.AWS_ACCESS_KEY_ID,
"accessKeyId");
config.setProperty(AWSConfigConstants.AWS_SECRET_ACCESS_KEY,
"secretKey");
FlinkKinesisConsumer<String> consumer = new
FlinkKinesisConsumer<>("fakeStream", new SimpleStringSchema(), config);
- assertTrue(consumer.snapshotState(123, 123) == null);
//arbitrary checkpoint id and timestamp
+ assertTrue(consumer.snapshotState(123, 123).size() == 0);
//arbitrary checkpoint id and timestamp
--- End diff --
For actual comparisons, it is nice to use `assertEquals`, because it shows
you the actual value is the error message.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
