fredia commented on code in PR #26107:
URL: https://github.com/apache/flink/pull/26107#discussion_r1948332722
##########
flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/ForStOptions.java:
##########
@@ -52,15 +52,16 @@ public class ForStOptions {
/** The remote directory where ForSt puts its SST files. */
@Documentation.Section(Documentation.Sections.STATE_BACKEND_FORST)
- public static final ConfigOption<String> REMOTE_DIRECTORY =
- ConfigOptions.key("state.backend.forst.remote-dir")
+ public static final ConfigOption<String> PRIMARY_DIRECTORY =
+ ConfigOptions.key("state.backend.forst.primary-dir")
.stringType()
- .noDefaultValue()
+ .defaultValue(CHECKPOINT_DIR_AS_PRIMARY_SHORTCUT)
.withDescription(
String.format(
- "The remote directory where ForSt puts its
SST files, fallback to %s if not configured."
- + " Recognized shortcut name is
'%s', which means that forst shares the directory with checkpoint.",
- LOCAL_DIRECTORIES.key(),
REMOTE_SHORTCUT_CHECKPOINT));
+ "The primary directory where ForSt puts
its SST files. By default, it will be the same as the checkpoint directory. "
+ + "Recognized shortcut name is
'%s', which means that ForSt shares the directory with checkpoint, "
+ + "and '%s', which means that
ForSt will use the local directory of TaskManager.",
+ LOCAL_DIRECTORIES.key(),
CHECKPOINT_DIR_AS_PRIMARY_SHORTCUT));
Review Comment:
LOCAL_DIRECTORIES -> LOCAL_DIR_AS_PRIMARY_SHORTCUT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
