zhuzhurk commented on code in PR #26127:
URL: https://github.com/apache/flink/pull/26127#discussion_r1948529561


##########
flink-runtime/src/main/java/org/apache/flink/streaming/api/graph/AdaptiveGraphManager.java:
##########
@@ -618,6 +619,15 @@ && isChainableSource(
                                     
streamGraph.getStreamNode(edge.getSourceId()), streamGraph))
                     || isChainable(edge, streamGraph)) {
                 edge.setPartitioner(new ForwardPartitioner<>());
+
+                // Because the exchange mode of 
ForwardForConsecutiveHashPartitioner might be Batch.
+                // So here we need to modify the exchange mode to UNDEFINED 
for edge with
+                // ForwardForConsecutiveHashPartitioner to make this edge 
chainable.

Review Comment:
   // ForwardForConsecutiveHashPartitioner may use BATCH exchange mode, which 
prevents operator chaining.
   // To enable chaining for edges using this partitioner, we need to set their 
exchange mode to UNDEFINED.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to