AHeise commented on code in PR #151:
URL:
https://github.com/apache/flink-connector-kafka/pull/151#discussion_r1949141658
##########
flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaWriterTestBase.java:
##########
@@ -227,6 +246,13 @@ public ProducerRecord<byte[], byte[]> serialize(
}
return new ProducerRecord<>(topic,
ByteBuffer.allocate(4).putInt(element).array());
}
+
+ @Override
+ public Optional<KafkaDatasetFacet> getKafkaDatasetFacet() {
+ return Optional.of(
+ new DefaultKafkaDatasetFacet(
+
DefaultKafkaDatasetIdentifier.ofTopics(Arrays.asList(topic))));
+ }
Review Comment:
Not necessary for this PR, will revert.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
