lvyanquan commented on code in PR #3856:
URL: https://github.com/apache/flink-cdc/pull/3856#discussion_r1950747543
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/table/MySqlTableSourceFactory.java:
##########
@@ -198,6 +201,7 @@ public Set<ConfigOption<?>> optionalOptions() {
options.add(MySqlSourceOptions.SCAN_INCREMENTAL_SNAPSHOT_BACKFILL_SKIP);
options.add(MySqlSourceOptions.PARSE_ONLINE_SCHEMA_CHANGES);
options.add(MySqlSourceOptions.USE_LEGACY_JSON_FORMAT);
+
options.add(MySqlSourceOptions.SCAN_INCREMENTAL_SNAPSHOT_ASSIGN_ENDING_CHUNK_FIRST);
Review Comment:
This was not added in other connectors.
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-cdc-base/src/main/java/org/apache/flink/cdc/connectors/base/config/JdbcSourceConfigFactory.java:
##########
@@ -252,6 +254,14 @@ public JdbcSourceConfigFactory
scanNewlyAddedTableEnabled(boolean scanNewlyAdded
return this;
}
+ /**
+ * Whether to assign the ending chunk first during snapshot reading phase.
Defaults to false.
+ */
+ public JdbcSourceConfigFactory assignEndingChunkFirst(boolean
assignEndingChunkFirst) {
Review Comment:
Could not find anywhere that call this method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
