xuyangzhong commented on code in PR #25637:
URL: https://github.com/apache/flink/pull/25637#discussion_r1954441128
##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/aggregate/window/processors/WindowAggProcessorBase.java:
##########
@@ -91,6 +91,9 @@ public void open(C context) throws Exception {
public void initializeWatermark(long watermark) {
if (isEventTime) {
currentProgress = watermark;
+ // Restore the watermark of timerService to prevent expired data
from being treated as
+ // not expired when flushWindowBuffer is executed.
+ windowTimerService.initializeWatermark(watermark);
Review Comment:
nit: Can we move this logic to the part where the `internalTimerService` is
created in `WindowAggOperator#open`? I think it might be easier to maintain.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
