AHeise commented on code in PR #139:
URL:
https://github.com/apache/flink-connector-kafka/pull/139#discussion_r1957071526
##########
flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/internals/KafkaTopicPartitionTest.java:
##########
@@ -26,14 +27,14 @@
import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.fail;
-/** Tests for the {@link KafkaTopicPartition}. */
+/** Tests for the {@link TopicPartition}. */
public class KafkaTopicPartitionTest {
@Test
public void validateUid() {
Review Comment:
Note that the test at it's current state is absolutely meaningless.
##########
flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/internals/KafkaTopicPartitionTest.java:
##########
@@ -26,14 +27,14 @@
import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.fail;
-/** Tests for the {@link KafkaTopicPartition}. */
+/** Tests for the {@link TopicPartition}. */
public class KafkaTopicPartitionTest {
@Test
public void validateUid() {
Review Comment:
You can remove this whole class. With Flink 2.0, we will not be able to
restore state from old consumers anyways.
We should document (and I think this applies to Flink 2.0 more than to Kafka
4.0) that users need to migrate from SourceFunction/SinkFunction to Source/Sink
with Flink 1.20 before switching to Flink 2.0.
##########
flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaShortRetentionTestBase.java:
##########
@@ -128,67 +118,6 @@ public static void shutDownServices() throws Exception {
*/
private static boolean stopProducer = false;
- public void runAutoOffsetResetTest() throws Exception {
Review Comment:
Remove entire class?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
