libenchao commented on code in PR #25919:
URL: https://github.com/apache/flink/pull/25919#discussion_r1958203973
##########
flink-formats/flink-json/src/test/java/org/apache/flink/formats/json/canal/CanalJsonSerDeSchemaTest.java:
##########
@@ -77,6 +79,32 @@ void testFilteringTables() throws Exception {
runTest(lines, deserializationSchema);
}
+ @Test
+ void testIgnoreParseErrors() throws Exception {
+ List<String> lines = readLines("canal-data-parse-error.txt");
Review Comment:
Can you just use existing 'canal-data.txt'
##########
flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/canal/CanalJsonDeserializationSchema.java:
##########
@@ -100,6 +101,9 @@ public final class CanalJsonDeserializationSchema
implements DeserializationSche
/** Pattern of the specific table. */
private final Pattern tablePattern;
+ /** List of data to be processed. */
+ private final List<GenericRowData> genericRowDataList = new ArrayList<>();
Review Comment:
The field can be `transient`, to avoid the serialization/deserialization.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
