gyfora commented on code in PR #944:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/944#discussion_r1960993002
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/observer/deployment/AbstractFlinkDeploymentObserver.java:
##########
@@ -152,7 +152,10 @@ protected void
observeJmDeployment(FlinkResourceContext<FlinkDeployment> ctx) {
}
deploymentStatus.setJobManagerDeploymentStatus(JobManagerDeploymentStatus.MISSING);
- deploymentStatus.getJobStatus().setState(JobStatus.RECONCILING);
+
+ if (!ReconciliationUtils.isJobInTerminalState(deploymentStatus)) {
+ deploymentStatus.getJobStatus().setState(JobStatus.RECONCILING);
Review Comment:
Can you please add a unit test to guard this change against accidental
future regressions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
