morhidi commented on PR #945: URL: https://github.com/apache/flink-kubernetes-operator/pull/945#issuecomment-2669434319
> Why would we close it? I think the PR makes sense , but it would be good to be able to configure the behavior as Max suggested > Perhaps we can add an option to allow collecting metrics in the stabilization phase? > Why would we close it? I think the PR makes sense , but it would be good to be able to configure the behavior as Max suggested > I'm not 100% sure this change will yield the desired outcome. There are some issues with collecting metrics in the stabilization phase, which is why we explicitly chose to not collect any that phase: > > Metrics are not available yet which will be evident in exceptions from the Rest API > Metrics may be incomplete > Metrics values will be skewed in the stabilization phase. > After this change, there is no way to externally asses the source-of-truth metrics which will be used for evaluation. This makes debugging the autoscaling algorithm harder. > > Perhaps we can add an option to allow collecting metrics in the stabilization phase? I guess Max is under the assumption that the current logic does not collect metrics during the stabilization period. This PR does not change that logic, so not sure what should be controlled by a flag. The only thing the PR does is that it reports those metrics. Can you clarify? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
