leonardBang commented on code in PR #3856:
URL: https://github.com/apache/flink-cdc/pull/3856#discussion_r1964634199
##########
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-mysql/src/main/java/org/apache/flink/cdc/connectors/mysql/source/MySqlDataSourceOptions.java:
##########
@@ -313,4 +313,12 @@ public class MySqlDataSourceOptions {
.defaultValue(true)
.withDescription(
"Whether to use legacy json format. The default
value is true, which means there is no whitespace before value and after comma
in json format.");
+
+ @Experimental
+ public static final ConfigOption<Boolean>
SCAN_INCREMENTAL_SNAPSHOT_ASSIGN_ENDING_CHUNK_FIRST =
+
ConfigOptions.key("scan.incremental.snapshot.assign-ending-chunk-first.enabled")
Review Comment:
I mean
ConfigOptions.key("scan.incremental.snapshot.boundary-chunk-first.enabled")
with default value `true`, currently we assign first chunk(unboundary chunk)
and then assign boundary chunk, right?
But the two ConfigOptions make sense to me when you use different default
value, feel free to choose you flavor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
