becketqin commented on code in PR #26188:
URL: https://github.com/apache/flink/pull/26188#discussion_r1965966467
##########
flink-connectors/flink-connector-base/src/test/java/org/apache/flink/connector/base/source/reader/fetcher/SplitFetcherManagerTest.java:
##########
@@ -70,7 +70,7 @@ void testCloseFetcherWithException() throws Exception {
reader.setCloseWithException();
SplitFetcherManager<Object, TestingSourceSplit> fetcherManager =
createFetcher("test-split", reader, new Configuration());
- fetcherManager.close(1000L);
+ fetcherManager.close(30000L);
Review Comment:
No, it won't. Normally the close will return fairly quick (a few
milliseconds). The additional timeout is just to avoid occasional failures due
to slow machines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
