SinBex commented on code in PR #26180:
URL: https://github.com/apache/flink/pull/26180#discussion_r1966998857
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/processor/AdaptiveJoinProcessor.java:
##########
@@ -61,12 +61,12 @@ public ExecNodeGraph process(ExecNodeGraph execGraph,
ProcessorContext context)
@Override
protected void visitNode(ExecNode<?> node) {
visitInputs(node);
- // AdaptiveJoin conversion should be avoided when
there is a
+ // AdaptiveJoin conversion should be avoided when
there is a strict
Review Comment:
The comment here may be modified to: 'To avoid data correctness issues, we
will refrain from transforming join nodes with a strict KEEP_INPUT_AS_IS
constraint downstream. Meanwhile, deeper evaluations will be conducted in the
corresponding StreamGraphOptimizationStrategy.'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
