lvyanquan commented on code in PR #3791:
URL: https://github.com/apache/flink-cdc/pull/3791#discussion_r1967020092
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/table/MySqlReadableMetadata.java:
##########
@@ -103,6 +112,45 @@ public Object read(SourceRecord record) {
throw new UnsupportedOperationException(
"Please call read(RowData rowData) method
instead.");
}
+ }),
+
+ /** schema of the record that contain the row. */
+ SCHEMA(
+ "schema",
Review Comment:
Please update the description of
[metadata.list](https://github.com/apache/flink-cdc/blob/83ae36a854ffe37b5ea16a9cb0494b8651123f02/flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-mysql/src/main/java/org/apache/flink/cdc/connectors/mysql/source/MySqlDataSourceOptions.java#L278)
too.
And we should update
https://github.com/apache/flink-cdc/blob/e7964b160c1df3861571ba2199ba04d91d887ff2/flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-mysql/src/main/java/org/apache/flink/cdc/connectors/mysql/source/MySqlDataSource.java#L99
too.
Considering that this is a feature for pipeline only, we should implement
the interface of SupportedMetadataColumn?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
