martongreber commented on code in PR #8: URL: https://github.com/apache/flink-connector-kudu/pull/8#discussion_r1970342327
########## flink-connector-kudu/src/main/java/org/apache/flink/connector/kudu/source/split/KuduSourceSplitSerializer.java: ########## @@ -0,0 +1,54 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.connector.kudu.source.split; + +import org.apache.flink.core.io.SimpleVersionedSerializer; + +import java.io.IOException; + +/** The class that serializes and deserializes {@link KuduSourceSplit}. */ +public class KuduSourceSplitSerializer implements SimpleVersionedSerializer<KuduSourceSplit> { + + private static final int VERSION = 1; // Versioning for future changes + + @Override + public int getVersion() { + return VERSION; + } + + @Override + public byte[] serialize(KuduSourceSplit obj) throws IOException { + if (obj == null || obj.getSerializedScanToken() == null) { + throw new IOException("KuduSourceSplit or serializedScanToken is null."); + } + + return obj.getSerializedScanToken(); // Directly return the byte array + } + + @Override + public KuduSourceSplit deserialize(int version, byte[] serialized) throws IOException { + if (version != VERSION) { + throw new IOException("Unsupported version: " + version); Review Comment: make sense, changed to IllegalArgumentException. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
