twalthr commented on code in PR #26217:
URL: https://github.com/apache/flink/pull/26217#discussion_r1973403212
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/PlanReference.java:
##########
@@ -160,6 +167,43 @@ public String toString() {
}
}
+ /** Plan reference to a string containing the serialized persisted plan in
Smile. */
+ @Experimental
Review Comment:
Make this and the class above PublicEvolving
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/serde/ContextResolvedTableJsonDeserializer.java:
##########
@@ -73,15 +73,15 @@ public ContextResolvedTable deserialize(JsonParser
jsonParser, DeserializationCo
// Deserialize the two fields, if available
final ObjectIdentifier identifier =
- JsonSerdeUtil.deserializeOptionalField(
+ JsonSmileSerdeUtil.deserializeOptionalField(
Review Comment:
```suggestion
CompiledPlanSerdeUtil.deserializeOptionalField(
```
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/PlanReference.java:
##########
@@ -160,6 +167,43 @@ public String toString() {
}
}
+ /** Plan reference to a string containing the serialized persisted plan in
Smile. */
+ @Experimental
Review Comment:
Rename `ContentPlanReference` to `JsonContentPlanReference` and this class
to `BytesContentPlanReference`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
