lvyanquan commented on code in PR #3912:
URL: https://github.com/apache/flink-cdc/pull/3912#discussion_r1976847009
##########
flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/operators/schema/regular/SchemaCoordinator.java:
##########
@@ -73,16 +75,13 @@ public class SchemaCoordinator extends SchemaRegistry {
/** Executor service to execute schema change. */
private final ExecutorService schemaChangeThreadPool;
- /**
- * Atomic flag indicating if current RequestHandler could accept more
schema changes for now.
- */
- private transient RequestStatus schemaChangeStatus;
-
/** Sink writers which have sent flush success events for the request. */
private transient ConcurrentHashMap<Integer, Set<Integer>>
flushedSinkWriters;
- /** Currently handling request's completable future. */
- private transient CompletableFuture<CoordinationResponse>
pendingResponseFuture;
+ /** Currently handling requests' completable future. */
+ private transient Map<
+ Integer, Tuple2<SchemaChangeRequest,
CompletableFuture<CoordinationResponse>>>
Review Comment:
Can you help add a comment that explains the key here as they are Integer
type which cannot directly discern the meaning it represents, and update the
comment of ` flushedSinkWriters` too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
