[ 
https://issues.apache.org/jira/browse/FLINK-33634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17933676#comment-17933676
 ] 

lajith commented on FLINK-33634:
--------------------------------

As mentioned in the FLIP , we will have status.conditions, which holds the list 
of condition that contains 
the status of Job transitions in each stage. Apart from status.conditions, we 
will have status.phase , 
which will provide the high level current status of Job, such as like 
Running,Finished etc..

Openshift UI was designed in such a way that, if there are multiple conditions 
, and at any point one 
of the condtion had a flag of status with true and type as Running , 
irrespetive of latest condition status has a 
flag as of false and type Running , UI says that condition of deployment /job 
is 
Running. Which is of misleading information, if suppose Job was running and 
then later point job was suspended. 

So while keeping the status.phase apart from condition will provide the exact 
current status of deployment/job in openshift UI. (It is same as 
like how k8s pod is having status.conditions and status.phase)

> Add Conditions to Flink CRD's Status field
> ------------------------------------------
>
>                 Key: FLINK-33634
>                 URL: https://issues.apache.org/jira/browse/FLINK-33634
>             Project: Flink
>          Issue Type: Improvement
>          Components: Kubernetes Operator
>    Affects Versions: kubernetes-operator-1.7.0
>            Reporter: Tony Garrard
>            Priority: Major
>              Labels: pull-request-available
>
> From 
> [https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#typical-status-properties]
>  it is considered best practice to provide Conditions in the Status of CRD's. 
> Some tooling even expects there to be a Conditions field in the status of a 
> CR. This issue to to propose adding a Conditions field to the CR status
> e.g.
> status:
>     conditions:
>      - lastTransitionTime: '2023-11-23T12:38:51Z'
>        status: 'True'
>        type: Ready



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to