vahmed-hamdy commented on code in PR #26274: URL: https://github.com/apache/flink/pull/26274#discussion_r1989579254
########## flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/Batch.java: ########## @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.connector.base.sink.writer; + +import org.apache.flink.annotation.PublicEvolving; + +import java.io.Serializable; +import java.util.List; + +/** + * A container for the result of creating a batch of request entries, including: + * + * <ul> + * <li>The actual list of entries forming the batch + * <li>The total size in bytes of those entries + * <li>The total number of entries in the batch + * </ul> + * + * <p>Instances of this class are typically created by a {@link BatchCreator} to summarize which + * entries have been selected for sending downstream and to provide any relevant metrics for + * tracking, such as the byte size or the record count. + * + * @param <RequestEntryT> the type of request entry in this batch + */ +@PublicEvolving Review Comment: yeah I don't have a strong opinion here, I also see classes like `AsyncSinkWriterConfiguration` and `RateLimitingStrategy` marked `PublicEvolving` for the same reason. let's keep it then -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
