lvyanquan commented on code in PR #3904: URL: https://github.com/apache/flink-cdc/pull/3904#discussion_r1991392104
########## flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-iceberg/src/main/java/org/apache/flink/cdc/connectors/iceberg/sink/IcebergDataSinkOptions.java: ########## @@ -0,0 +1,60 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.cdc.connectors.iceberg.sink; + +import org.apache.flink.cdc.common.configuration.ConfigOption; + +import static org.apache.flink.cdc.common.configuration.ConfigOptions.key; + +/** Config options for {@link IcebergDataSink}. */ +public class IcebergDataSinkOptions { + + // prefix for passing properties for table creation. + public static final String PREFIX_TABLE_PROPERTIES = "table.properties."; + + // prefix for passing properties for catalog creation. + public static final String PREFIX_CATALOG_PROPERTIES = "catalog.properties."; + + public static final ConfigOption<String> TYPE = + key("catalog.properties.type") + .stringType() + .noDefaultValue() + .withDescription("Type of iceberg catalog, supports `hadoop` and `hive`."); + + public static final ConfigOption<String> WAREHOUSE = + key("catalog.properties.warehouse") + .stringType() + .noDefaultValue() + .withDescription( + "The warehouse root path of catalog, only usable when catalog.properties.type is `hadoop`."); + + public static final ConfigOption<String> URI = + key("catalog.properties.uri") + .stringType() + .noDefaultValue() + .withDescription("Uri of metastore server."); + + public static final ConfigOption<String> PARTITION_KEY = + key("partition.key") + .stringType() + .defaultValue("") + .withDescription( + "Partition keys for each partitioned table, allow setting multiple primary keys for multiTables. " + + "Tables are separated by ';', and partition keys are separated by ','. " + + "For example, we can set partition.key of two tables by 'testdb.table1:id1,id2;testdb.table2:name'."); Review Comment: Sure, we should support more partition transform function. However, a thorny issue is how to configure this transformation, as it takes effect on fields, and we usually have many tables and fields that are too complex to configure one by one. We need a more elegant configuration scheme. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
