ammu20-dev commented on PR #25656: URL: https://github.com/apache/flink/pull/25656#issuecomment-2710137431
Here is the summary on the outcomes from the PR review: 1. Externally added jars are resolved using the FlinkUserCodeClassLoader(child classloader) in flink. This fix involved updating the class loader at the graph execution level with the user code class loader which is expected as per naming convention of the variable [here](https://github.com/apache/flink/blob/a4563caa7a4914dfd9fa5d488f5b2e541ecc582a/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java#L2472) in the source code. 2. However, the issue is already fixed in a safe tested way in Flink 2.0 as part of this [PR](https://github.com/apache/flink/pull/25472). If this issue exists for several Flink versions (from 1.16) then we should not introduce large and risky changes in a patch version to fix it. 3. Since the issue has existed since version 1.16 (over 2 years) and is only relevant for the Table API the risk is not worth it(see [comment](https://github.com/apache/flink/pull/25656#issuecomment-2582320914)). So we can conclude that ADD JAR capability with Table API will be a known limitation till version 20 and the same can be used with Flink 2.0. Based on the above findings I am closing this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
