[ 
https://issues.apache.org/jira/browse/FLINK-2821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15751950#comment-15751950
 ] 

ASF GitHub Bot commented on FLINK-2821:
---------------------------------------

Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2917#discussion_r92658254
  
    --- Diff: 
flink-runtime/src/main/scala/org/apache/flink/runtime/akka/AkkaUtils.scala ---
    @@ -102,21 +102,24 @@ object AkkaUtils {
        * specified, then the actor system will listen on the respective 
address.
        *
        * @param configuration instance containing the user provided 
configuration values
    -   * @param listeningAddress optional tuple of hostname and port to listen 
on. If None is given,
    -   *                         then an Akka config for local actor system 
will be returned
    +   * @param externalAddress optional tuple of hostname and port to be 
reachable at.
    +   *                        If None is given, then an Akka config for 
local actor system
    +   *                        will be returned
        * @return Akka config
        */
       @throws(classOf[UnknownHostException])
       def getAkkaConfig(configuration: Configuration,
    -                    listeningAddress: Option[(String, Int)]): Config = {
    +                    externalAddress: Option[(String, Int)]): Config = {
         val defaultConfig = getBasicAkkaConfig(configuration)
     
    -    listeningAddress match {
    +    externalAddress match {
     
           case Some((hostname, port)) =>
    -        val ipAddress = InetAddress.getByName(hostname)
    -        val hostString = "\"" + NetUtils.ipAddressToUrlString(ipAddress) + 
"\""
    -        val remoteConfig = getRemoteAkkaConfig(configuration, hostString, 
port)
    +
    +        val remoteConfig = getRemoteAkkaConfig(configuration,
    +          NetUtils.getWildcardIPAddress, port,
    --- End diff --
    
    +1


> Change Akka configuration to allow accessing actors from different URLs
> -----------------------------------------------------------------------
>
>                 Key: FLINK-2821
>                 URL: https://issues.apache.org/jira/browse/FLINK-2821
>             Project: Flink
>          Issue Type: Bug
>          Components: Distributed Coordination
>            Reporter: Robert Metzger
>            Assignee: Maximilian Michels
>
> Akka expects the actor's URL to be exactly matching.
> As pointed out here, cases where users were complaining about this: 
> http://apache-flink-user-mailing-list-archive.2336050.n4.nabble.com/Error-trying-to-access-JM-through-proxy-td3018.html
>   - Proxy routing (as described here, send to the proxy URL, receiver 
> recognizes only original URL)
>   - Using hostname / IP interchangeably does not work (we solved this by 
> always putting IP addresses into URLs, never hostnames)
>   - Binding to multiple interfaces (any local 0.0.0.0) does not work. Still 
> no solution to that (but seems not too much of a restriction)
> I am aware that this is not possible due to Akka, so it is actually not a 
> Flink bug. But I think we should track the resolution of the issue here 
> anyways because its affecting our user's satisfaction.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to