beliefer commented on code in PR #26321:
URL: https://github.com/apache/flink/pull/26321#discussion_r2002952066
##########
flink-runtime/src/main/java/org/apache/flink/streaming/api/windowing/assigners/SlidingEventTimeWindows.java:
##########
@@ -59,6 +59,11 @@ protected SlidingEventTimeWindows(long size, long slide,
long offset) {
"SlidingEventTimeWindows parameters must satisfy "
+ "abs(offset) < slide and size > 0");
}
+ if (size / slide > 10000000) {
Review Comment:
I test on my local environment, OOM occurs if it is bigger than 2000000+, so
I set 1000000 here.
I want introduce a config, but there is no chance to visit `Configuration`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
