zlzhang0122 commented on PR #26263: URL: https://github.com/apache/flink/pull/26263#issuecomment-2739544692
> I notice the CI is failing with > > ``` > 03:33:57.572 [ERROR] src/main/java/org/apache/flink/table/planner/plan/rules/logical/WindowPropertiesRules.java:[33,1] (imports) IllegalImport: com.google.common.collect.Iterables; Use flink-shaded-guava instead. > 03:33:57.572 [ERROR] src/main/java/org/apache/flink/table/planner/plan/rules/logical/WindowPropertiesRules.java:[34,1] (imports) IllegalImport: com.google.common.collect.Lists; Use flink-shaded-guava instead. > 03:33:57.572 [ERROR] src/main/java/org/apache/flink/table/planner/plan/rules/logical/JoinDeriveNullFilterRule.java:[23,1] (imports) IllegalImport: com.google.common.collect.Lists; Use flink-shaded-guava instead. > 03:33:57.572 [ERROR] src/main/java/org/apache/flink/table/planner/plan/rules/logical/EventTimeTemporalJoinRewriteRule.java:[31,1] (imports) IllegalImport: com.google.common.collect.Lists; Use flink-shaded-guava instead. > 03:33:57.572 [ERROR] src/main/java/org/apache/flink/table/planner/plan/nodes/exec/stream/StreamExecIntervalJoin.java:[60,1] (imports) IllegalImport: com.google.common.collect.Lists; Use flink-shaded-guava instead. > 03:33:57.572 [ERROR] src/main/java/org/apache/flink/table/planner/plan/nodes/exec/stream/StreamExecJoin.java:[54,1] (imports) IllegalImport: com.google.common.collect.Lists; Use flink-shaded-guava instead. > 03:33:57.572 [ERROR] src/main/java/org/apache/flink/table/planner/plan/nodes/exec/stream/StreamExecWindowJoin.java:[52,1] (imports) IllegalImport: com.google.common.collect.Lists; Use flink-shaded-guava instead. > 03:33:57.572 [ERROR] src/test/java/org/apache/flink/table/planner/plan/hints/batch/JoinHintTestBase.java:[34,1] (imports) IllegalImport: com.google.common.collect.Lists; Use flink-shaded-guava instead. > 0 > ``` > > It would be good to understand why we are using the shading - what more do we need to do to remove it. IMO we should use the shaded jar version in case of jar version conflict, maybe we should change them to shading version to get rid of conflict between flink cluster jars and user jars. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
