davidradl commented on code in PR #26297:
URL: https://github.com/apache/flink/pull/26297#discussion_r2005783270
##########
flink-runtime/src/main/java/org/apache/flink/streaming/api/datastream/DataStream.java:
##########
@@ -864,7 +864,11 @@ protected DataStream<T>
setConnectionType(StreamPartitioner<T> partitioner) {
*
* @param sinkFunction The object containing the sink's invoke function.
* @return The closed DataStream.
+ * @deprecated This method relies on the {@link SinkFunction} API, which
is due to be removed.
Review Comment:
I see text "due to be removed." but this does seem to match with the PR this
refers to which talks of :
The referred to PR has a description indicating the intent
```
Rename SourceFunction / SinkFunction to LegacySourceFunction /
LegacySinkFunction, and mark them as Internal interface. Some class that
implemented SourceFunction / SinkFunction with PublicEvolving were also renamed.
Remove Sink V1 API and relevant usage.
```
I was thinking that to complete the original PR we need to change all
references of `SinkFunction` to
`LegacySinkFunction` why is this change still referring to `SinkFunction`.
Am I understanding this correctly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
