davidradl commented on PR #26332: URL: https://github.com/apache/flink/pull/26332#issuecomment-2743098691
I see other long arrays - why did you choose this one to change to be atomic? Can an instance of this class be used by more than one thread? As this class extends thread - I was assuming that the instance of this class is only associated with one thread. I could imagine the system resources we are accessing like networkIF and cpu clicks could change underneath us if another thread updates them. But why does this variable need to be made atomic? One way to show this needs changing would be to add a unit test that shows the how the existing long[] is problematic due to thread access. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
