davidradl commented on code in PR #26326:
URL: https://github.com/apache/flink/pull/26326#discussion_r2007644535
##########
flink-core/src/main/java/org/apache/flink/configuration/CoreOptions.java:
##########
@@ -527,23 +527,41 @@ public static String[] mergeListsToArray(List<String>
base, List<String> append)
* open. Unlimited be default.
*/
public static ConfigOption<Integer> fileSystemConnectionLimit(String
scheme) {
- return ConfigOptions.key("fs." + scheme +
".limit.total").intType().defaultValue(-1);
+ return ConfigOptions.key("fs." + scheme + ".limit.total")
+ .intType()
+ .defaultValue(-1)
+ .withDescription(
+ "The connection limit for the file system "
+ + scheme
+ + ". The valid value must >= -1. Values of -1
or 0 mean there is no connection limit.");
}
/**
* The total number of input connections that a file system for the given
scheme may open.
* Unlimited be default.
*/
public static ConfigOption<Integer> fileSystemConnectionLimitIn(String
scheme) {
- return ConfigOptions.key("fs." + scheme +
".limit.input").intType().defaultValue(-1);
+ return ConfigOptions.key("fs." + scheme + ".limit.input")
Review Comment:
nit: as the 3 configurations only differ with the key and first word(s) of
the description, could we define a method with the common code. Maybe a common
method with connectionLimitType.
send in "total" "input" or "output" as connectionLimitType
key would have
.limit. + connectionLimitType
and the description could start
"The " + connectionLimitType + " connection limit ....
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
