[
https://issues.apache.org/jira/browse/FLINK-37558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chanhyeong Cho updated FLINK-37558:
-----------------------------------
Affects Version/s: 1.20.1
> Check right variable in MetricRegistryImpl#addSpan
> --------------------------------------------------
>
> Key: FLINK-37558
> URL: https://issues.apache.org/jira/browse/FLINK-37558
> Project: Flink
> Issue Type: Improvement
> Affects Versions: 1.20.1
> Reporter: Chanhyeong Cho
> Priority: Minor
> Labels: pull-request-available
>
> Looking at the null check cases for 'reporters' in MetricRegistryImpl, the
> null check in addSpan should be changed to the null check for
> 'traceReporters' rather than 'reporters', because
> notifyTraceReportersOfAddedSpan method uses 'traceReporters', not 'reporters'.
> The null check may be meaningless because all reporters values are
> initialized to empty ArrayList from the constructor, but I'd like to make the
> change for the correct check.
>
> https://github.com/apache/flink/blob/0c35363f93cbe0d48bc1b8e9e6e7624565323280/flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistryImpl.java#L466-L468
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
