Mrart commented on PR #3643: URL: https://github.com/apache/flink-cdc/pull/3643#issuecomment-2754211245
> Hi @MOBIN-F, thanks for your contribution! Could you please rebase this PR with latest `master` when available? > > Code style verifier has been updated to enforce JUnit 5 + AssertJ framework and these classes might need to be migrated: > > * JUnit 4 style test annotations should be changed to JUnit 5 equivalents > > * `org.junit.Test` => `org.junit.jupiter.api.Test` > * `@Before`, `@BeforeClass` => `@BeforeEach`, `@BeforeAll` > * `@After`, `@AfterClass` => `@AfterEach`, `@AfterAll` > * JUnit Assertions / Hamcrest Assertions are not allowed, including: > > * `org.junit.Assert` > * `org.junit.jupiter.api.Assertions` > * `org.hamcrest.*` > > `org.assertj.core.api.Assertions` should be used instead. > > Run `mvn verify -DskipTests` locally to check if all these requirements have been satisfied. [ERROR] src/test/java/org/apache/flink/cdc/pipeline/tests/utils/PipelineTestOnYarnEnvironment.java:[35,1] (imports) IllegalImport: org.junit.After; Please use JUnit 5 Jupiter API instead. [ERROR] src/test/java/org/apache/flink/cdc/pipeline/tests/utils/PipelineTestOnYarnEnvironment.java:[36,1] (imports) IllegalImport: org.junit.AfterClass; Please use JUnit 5 Jupiter API instead. [ERROR] src/test/java/org/apache/flink/cdc/pipeline/tests/utils/PipelineTestOnYarnEnvironment.java:[37,1] (imports) IllegalImport: org.junit.Before; Please use JUnit 5 Jupiter API instead. [ERROR] src/test/java/org/apache/flink/cdc/pipeline/tests/utils/PipelineTestOnYarnEnvironment.java:[38,1] (imports) IllegalImport: org.junit.Rule; Please use JUnit 5 Jupiter API instead. [ERROR] src/test/java/org/apache/flink/cdc/pipeline/tests/utils/PipelineTestOnYarnEnvironment.java:[39,1] (imports) IllegalImport: org.junit.rules.TemporaryFolder; Please use JUnit 5 Jupiter API instead. [ERROR] src/test/java/org/apache/flink/cdc/pipeline/tests/MysqlE2eWithYarnApplicationITCase.java:[26,1] (imports) IllegalImport: org.junit.After; Please use JUnit 5 Jupiter API instead. [ERROR] src/test/java/org/apache/flink/cdc/pipeline/tests/MysqlE2eWithYarnApplicationITCase.java:[27,1] (imports) IllegalImport: org.junit.Before; Please use JUnit 5 Jupiter API instead. [ERROR] src/test/java/org/apache/flink/cdc/pipeline/tests/MysqlE2eWithYarnApplicationITCase.java:[28,1] (imports) IllegalImport: org.junit.BeforeClass; Please use JUnit 5 Jupiter API instead. [ERROR] src/test/java/org/apache/flink/cdc/pipeline/tests/MysqlE2eWithYarnApplicationITCase.java:[29,1] (imports) IllegalImport: org.junit.ClassRule; Please use JUnit 5 Jupiter API instead. [ERROR] src/test/java/org/apache/flink/cdc/pipeline/tests/MysqlE2eWithYarnApplicationITCase.java:[30,1] (imports) IllegalImport: org.junit.Test; Please use JUnit 5 Jupiter API instead. cc @MOBIN-F M -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
