gguptp commented on code in PR #193:
URL:
https://github.com/apache/flink-connector-aws/pull/193#discussion_r2014079810
##########
flink-connector-aws/flink-connector-dynamodb/src/main/java/org/apache/flink/connector/dynamodb/source/split/DynamoDbStreamsShardSplit.java:
##########
@@ -40,12 +40,22 @@ public final class DynamoDbStreamsShardSplit implements
SourceSplit {
private final String shardId;
private final StartingPosition startingPosition;
private final String parentShardId;
+ private final long finishedAfterCheckpoint;
Review Comment:
actuallly i would rather say the issue exists due to following:
- Enumerator checkpointed its state
- It asked reader to checkpoint
- Just before reader started checkpointing a SplitFinished event came
- Reader checkpointed its state
Now there is a gap between enumerator and reader in terms of enumerator
checkpointed first and reader checkpointed later
I guess from enumerator POV, this variable might be named as
finishedAfterCheckpoint, from reader POV it can be named as
finishedBeforeCheckpoint, so i'm in a dilemma what should be its name 😂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
