loserwang1024 commented on code in PR #3954:
URL: https://github.com/apache/flink-cdc/pull/3954#discussion_r2006919004
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-cdc-base/src/main/java/org/apache/flink/cdc/connectors/base/source/assigner/SnapshotSplitAssigner.java:
##########
@@ -366,16 +366,20 @@ private void splitTable(TableId nextTable) {
hasRecordSchema = true;
tableSchemas.putAll(splits.iterator().next().getTableSchemas());
}
- final List<SchemalessSnapshotSplit> schemalessSnapshotSplits =
- splits.stream()
- .map(SnapshotSplit::toSchemalessSnapshotSplit)
- .collect(Collectors.toList());
+ List<String> splitIds = new ArrayList<>();
+ for (SnapshotSplit split : splits) {
+ SchemalessSnapshotSplit schemalessSnapshotSplit =
+ split.toSchemalessSnapshotSplit();
+ splitIds.add(schemalessSnapshotSplit.splitId());
+ if (sourceConfig.isAssignUnboundedChunkFirst() &&
split.getSplitEnd() == null) {
Review Comment:
It's hard to add a test from mongo cdc which chunk size is MB rather than
number of record. The test which you have added also just returns one
snapshot split.It can not prove unbounded-chunk-first.enabled.
Any I noticed that currently mongo cdc is event and un-evently share same
logical, no need to modify it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
