ruanhang1993 commented on code in PR #3924: URL: https://github.com/apache/flink-cdc/pull/3924#discussion_r2017847069
########## docs/content/docs/connectors/flink-sources/mysql-cdc.md: ########## @@ -833,6 +833,30 @@ There are two places that need to be taken care of. * If no update operation is performed on the specified column, the exactly-once semantics is ensured. * If the update operation is performed on the specified column, only the at-least-once semantics is ensured. However, you can specify primary keys at downstream and perform the idempotence operation to ensure data correctness. +#### Warning Review Comment: Could you please add a link of this warning to `scan.incremental.snapshot.chunk.key-column` in the `Connector Options` table? `scan.incremental.snapshot.chunk.key-column` option need to be provided in this table. ########## docs/content/docs/connectors/flink-sources/mysql-cdc.md: ########## @@ -833,6 +833,30 @@ There are two places that need to be taken care of. * If no update operation is performed on the specified column, the exactly-once semantics is ensured. * If the update operation is performed on the specified column, only the at-least-once semantics is ensured. However, you can specify primary keys at downstream and perform the idempotence operation to ensure data correctness. +#### Warning + +Using a **non-primary key column** as the `scan.incremental.snapshot.chunk.key-column` can lead to data inconsistencies. Below is a scenario illustrating this issue and recommendations to mitigate potential problems. Review Comment: ```suggestion Using a **non-primary key column** as the `scan.incremental.snapshot.chunk.key-column` for a mysql table with primary keys may lead to data inconsistencies. Below is a scenario illustrating this issue and recommendations to mitigate potential problems. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
