leekeiabstraction commented on code in PR #195:
URL:
https://github.com/apache/flink-connector-aws/pull/195#discussion_r2028563400
##########
flink-connector-aws/flink-connector-aws-kinesis-streams/src/main/java/org/apache/flink/connector/kinesis/source/reader/polling/PollingKinesisShardSplitReader.java:
##########
@@ -40,6 +47,14 @@ public class PollingKinesisShardSplitReader extends
KinesisShardSplitReaderBase
private final Configuration configuration;
private final int maxRecordsToGet;
+ private final long getRecordsIntervalMillis;
+
+ private final long idleSourceGetRecordsIntervalMillis;
+
+ private long scheduledGetRecordTimeMillis = 0;
Review Comment:
Well spotted, I had the wrong assumption that we use a thread per split.
Addressed in latest commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
