davidradl commented on code in PR #26335:
URL: https://github.com/apache/flink/pull/26335#discussion_r2007521033


##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/utils/testTableSourceSinks.scala:
##########
@@ -329,12 +329,27 @@ class TestPartitionableTableSource(
 
   override def explainSource(): String = {
     if (remainingPartitions != null) {
-      s"partitions=${remainingPartitions.mkString(", ")}"
+      s"partitions=${remainingPartitions.map(sortMapKeys).mkString(", ")}"

Review Comment:
   thanks for checking this out. if we let the _.toSeq.sortBy( do most of the 
work - is there a simple way to turn the array buffer of tuples into the string 
we want? So we do not need to introduce a bespoke looping function? Does 
[https://stackoverflow.com/questions/26751441/scala-tuple-to-string-using-mkstring](https://stackoverflow.com/questions/26751441/scala-tuple-to-string-using-mkstring)
 help?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to