davidradl commented on code in PR #957:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/957#discussion_r2007917871
##########
flink-kubernetes-operator-api/src/main/java/org/apache/flink/kubernetes/operator/api/status/FlinkDeploymentStatus.java:
##########
@@ -55,4 +60,175 @@ public class FlinkDeploymentStatus extends
CommonStatus<FlinkDeploymentSpec> {
/** Information about the TaskManagers for the scale subresource. */
private TaskManagerInfo taskManager;
+
+ /** Condition of the CR . */
+ private List<Condition> conditions = new ArrayList<>();
+
+ private String phase;
+
+ public List<Condition> getConditions() {
+ if (reconciliationStatus != null
+ && reconciliationStatus.deserializeLastReconciledSpec() != null
+ &&
reconciliationStatus.deserializeLastReconciledSpec().getJob() == null) {
+ switch (jobManagerDeploymentStatus) {
+ case READY:
+ updateCondition(
+ conditions,
+ ConditionUtils.runningTrue(
+ "JobManager is running and ready to
receive REST API call",
+ "JobManager is running and ready to
receive REST API call"));
+ break;
+ case MISSING:
+ updateCondition(
+ conditions,
+ ConditionUtils.runningFalse(
+ "JobManager deployment not found",
+ "JobManager deployment not found"));
+ break;
+ case DEPLOYING:
+ updateCondition(
+ conditions,
+ ConditionUtils.runningFalse(
+ "JobManager process is starting up",
+ "JobManager process is starting up"));
Review Comment:
I am curious why the message and reaon is the same . I would expect them to
be different. In this case I would expect the reason to be "A New JVM
deployment exists and is being created" - i.e. the word on the arrow in the
UML.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
