rmetzger commented on code in PR #140:
URL:
https://github.com/apache/flink-connector-kafka/pull/140#discussion_r2015803052
##########
flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/dynamic/source/DynamicKafkaSourceITTest.java:
##########
@@ -805,30 +801,31 @@ private KafkaStream getKafkaStream(
new ClusterMetadata(Collections.singleton(topic),
properties)));
}
}
-
- /** Integration test based on connector testing framework. */
- @Nested
- class IntegrationTests extends SourceTestSuiteBase<String> {
- @TestSemantics
- CheckpointingMode[] semantics = new CheckpointingMode[]
{CheckpointingMode.EXACTLY_ONCE};
-
- // Defines test environment on Flink MiniCluster
- @SuppressWarnings("unused")
- @TestEnv
- MiniClusterTestEnvironment flink = new MiniClusterTestEnvironment();
-
- @TestExternalSystem
- DefaultContainerizedExternalSystem<TwoKafkaContainers> twoKafkas =
- DefaultContainerizedExternalSystem.builder()
- .fromContainer(new TwoKafkaContainers())
- .build();
-
- @SuppressWarnings("unused")
- @TestContext
- DynamicKafkaSourceExternalContextFactory twoClusters =
- new DynamicKafkaSourceExternalContextFactory(
- twoKafkas.getContainer().getKafka0(),
- twoKafkas.getContainer().getKafka1(),
- Collections.emptyList());
- }
+ //
+ // /** Integration test based on connector testing framework. */
+ // @Nested
+ // class IntegrationTests extends SourceTestSuiteBase<String> {
+ // @TestSemantics
+ // CheckpointingMode[] semantics = new CheckpointingMode[]
+ // {CheckpointingMode.EXACTLY_ONCE};
+ //
+ // // Defines test environment on Flink MiniCluster
+ // @SuppressWarnings("unused")
+ // @TestEnv
+ // MiniClusterTestEnvironment flink = new
MiniClusterTestEnvironment();
+ //
+ // @TestExternalSystem
+ // DefaultContainerizedExternalSystem<TwoKafkaContainers> twoKafkas
=
+ // DefaultContainerizedExternalSystem.builder()
+ // .fromContainer(new TwoKafkaContainers())
+ // .build();
+ //
+ // @SuppressWarnings("unused")
+ // @TestContext
+ // DynamicKafkaSourceExternalContextFactory twoClusters =
+ // new DynamicKafkaSourceExternalContextFactory(
+ // twoKafkas.getContainer().getKafka0(),
+ // twoKafkas.getContainer().getKafka1(),
+ // Collections.emptyList());
+ // }
}
Review Comment:
Why is this test commented out. I fear we are losing test coverage by this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
