beliefer commented on code in PR #26373:
URL: https://github.com/apache/flink/pull/26373#discussion_r2030429493
##########
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutorMemoryConfiguration.java:
##########
@@ -115,8 +116,8 @@ public static TaskExecutorMemoryConfiguration
create(Configuration config) {
getConfigurationValue(config, MANAGED_MEMORY_SIZE),
getConfigurationValue(config, JVM_METASPACE),
getConfigurationValue(config, JVM_OVERHEAD_MAX),
- calculateTotalFlinkMemoryFromComponents(config),
- calculateTotalProcessMemoryFromComponents(config));
+ totalFlinkMemory,
+ calculateTotalProcessMemoryFromComponents(config,
totalFlinkMemory));
}
Review Comment:
I think this change has a little improvement that cannot be watched from end
to end easily.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
