leonardBang commented on PR #3980:
URL: https://github.com/apache/flink-cdc/pull/3980#issuecomment-2785526486

   > Rename sink.debezium-json.include-schema.enabled to 
debezium-json.include-schema.enabled Reason:
   > 
   > 1. With the introduction of [[FLINK-37358][kafka] Support to pass format 
optionsĀ #3926](https://github.com/apache/flink-cdc/pull/3926), the 
createSerializationSchema constructor receives the formatoptions parameter 
(such as debezium-json.*/canal-json.* options)
   > 2. debezium-json.include-schema.enabled can be used for 
kafka-pipeline-source in the future
   >    What do you think? @lvyanquan
   > 
   > The first point is also the reason for CI failure
   
   makes sense to me


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to