davidradl commented on code in PR #26363:
URL: https://github.com/apache/flink/pull/26363#discussion_r2026940790
##########
flink-runtime/src/test/java/org/apache/flink/runtime/io/disk/FileChannelManagerImplTest.java:
##########
@@ -211,7 +211,7 @@ public static void main(String[] args) throws Exception {
if (callerHasHook) {
// Verifies the case that both FileChannelManager and its
upper component
// have registered shutdown hooks, like in IOManager.
- ShutdownHookUtil.addShutdownHook(() -> manager.close(),
"Caller", LOG);
+ ShutdownHookUtil.addShutdownHook(manager, "Caller", LOG);
Review Comment:
sorry. The changed code is in method
```
public IOManagerAsync(String[] tempDirs, ExecutorService executorService) {
super(tempDirs, executorService);
```
So to test this we need to drive this method. I think you have a test that
tests the same pattern but not the actual changed code.
am I missing something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
