leekeiabstraction commented on code in PR #26301:
URL: https://github.com/apache/flink/pull/26301#discussion_r2034738099
##########
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/services/HeadlessClusterIPService.java:
##########
@@ -50,6 +50,7 @@ public Service buildUpInternalService(
.withNewMetadata()
.withName(serviceName)
.withLabels(kubernetesJobManagerParameters.getCommonLabels())
+
.addToLabels(kubernetesJobManagerParameters.getInternalServiceLabels())
Review Comment:
nit: Should line 52 be changed to use `addToLabels` method as well? This is
so that the code will be more robust to breakage due to line re-ordering as
`withLabels` replaces labels map inside the ServiceBuilder.
##########
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/services/HeadlessClusterIPService.java:
##########
@@ -50,6 +50,7 @@ public Service buildUpInternalService(
.withNewMetadata()
.withName(serviceName)
.withLabels(kubernetesJobManagerParameters.getCommonLabels())
+
.addToLabels(kubernetesJobManagerParameters.getInternalServiceLabels())
Review Comment:
nit: Should line 52 be changed to use `addToLabels` method as well? This is
so that the code will be more robust to breakage due to line re-ordering as
`withLabels` replaces labels map inside the ServiceBuilder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
