[
https://issues.apache.org/jira/browse/FLINK-5084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15767299#comment-15767299
]
ASF GitHub Bot commented on FLINK-5084:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2977#discussion_r93448930
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/batch/table/AggregationsITCase.scala
---
@@ -400,5 +342,23 @@ class AggregationsITCase(
TestBaseUtils.compareResultAsText(results.asJava, expected)
}
+ @Test
+ def testPojoGrouping() {
--- End diff --
This test is not testing a Table API aggregation or grouping. I think it
can be removed and the `MyPojo` class as well.
> Replace Java Table API integration tests by unit tests
> ------------------------------------------------------
>
> Key: FLINK-5084
> URL: https://issues.apache.org/jira/browse/FLINK-5084
> Project: Flink
> Issue Type: Task
> Components: Table API & SQL
> Reporter: Fabian Hueske
> Priority: Minor
>
> The Java Table API is a wrapper on top of the Scala Table API.
> Instead of operating directly with Expressions like the Scala API, the Java
> API accepts a String parameter which is parsed into Expressions.
> We could therefore replace the Java Table API ITCases by tests that check
> that the parsing step produces a valid logical plan.
> This could be done by creating two {{Table}} objects for an identical query
> once with the Scala Expression API and one with the Java String API and
> comparing the logical plans of both {{Table}} objects. Basically something
> like the following:
> {code}
> val ds1 = CollectionDataSets.getSmall3TupleDataSet(env).toTable(tEnv, 'a, 'b,
> 'c)
> val ds2 = CollectionDataSets.get5TupleDataSet(env).toTable(tEnv, 'd, 'e, 'f,
> 'g, 'h)
> val joinT1 = ds1.join(ds2).where('b === 'e).select('c, 'g)
> val joinT2 = ds1.join(ds2).where("b = e").select("c, g")
> val lPlan1 = joinT1.logicalPlan
> val lPlan2 = joinT2.logicalPlan
> Assert.assertEquals("Logical Plans do not match", lPlan1, lPlan2)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
