ruanhang1993 commented on PR #3914: URL: https://github.com/apache/flink-cdc/pull/3914#issuecomment-2789002087
@beryllw Thanks for your contribution. This PR has 2 problems. 1. The metrics in https://github.com/apache/flink-cdc/pull/3619/files relies on the change of states. But mysql cdc connector does not use the framework in `flink-cdc-base`. So some metrics in SourceReaderMetrics will be wrong. 2. Is it a good idea that MySQL cdc connector introduce the `flink-cdc-base` dependency in this PR? Maybe we could introduce these metrics when we complete the task to refactor mysql cdc connetor with `flink-cdc-base`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
