ferenc-csaky commented on code in PR #26428:
URL: https://github.com/apache/flink/pull/26428#discussion_r2040031414
##########
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java:
##########
@@ -301,14 +296,9 @@ private Configuration getEffectiveConfiguration(
}
private <T> Configuration getEffectiveConfiguration(
- final CustomCommandLine activeCustomCommandLine,
- final CommandLine commandLine,
+ final Configuration effectiveConfiguration,
Review Comment:
I think we should rename this method to `updateEffectiveConfiguration`,
cause it refers better to what it does with the changed logic.
A difference worth mentioning is that now it mutates the passed
`effectiveConfigration`, so even if you declare a `Configuration` object
`final`, calling this method on it will change its state, which is a new
behavior compared to how it was before. Example:
```java
final Configuration conf = getEffectiveConfiguration(...);
updateEffectiveConfiguration(conf, ...);
// ^ after this call `conf` will probably not be the same.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
