beliefer commented on code in PR #26426:
URL: https://github.com/apache/flink/pull/26426#discussion_r2043712867
##########
flink-core/src/main/java/org/apache/flink/configuration/Configuration.java:
##########
@@ -239,9 +239,21 @@ public void addAllToProperties(Properties props) {
}
public void addAll(Configuration other) {
- synchronized (this.confData) {
Review Comment:
Yes. Let me take an example. There are two objects A and B. The hash value
of Object A is smaller than Object B's.
Thread 1 holds the Object A and thread 2 holds the Object B. Thread 1 will
lock Object A first and then Object B. Thread 2 wants lock Object B first but
it can't since the hash value of Object A is lower than Object B, so this
thread still needs lock Object A first and then Object B.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
