davidradl commented on code in PR #26463:
URL: https://github.com/apache/flink/pull/26463#discussion_r2044523740
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/stream/StreamExecIntervalJoin.java:
##########
@@ -392,25 +412,46 @@ private TwoInputTransformation<RowData, RowData, RowData>
createRowTimeJoin(
(InternalTypeInfo<RowData>) leftInputTransform.getOutputType();
InternalTypeInfo<RowData> rightTypeInfo =
(InternalTypeInfo<RowData>)
rightInputTransform.getOutputType();
- RowTimeIntervalJoin rowJoinFunc =
- new RowTimeIntervalJoin(
- joinSpec.getJoinType(),
- windowBounds.getLeftLowerBound(),
- windowBounds.getLeftUpperBound(),
- 0L, // allowedLateness
- minCleanUpIntervalMillis,
- leftTypeInfo,
- rightTypeInfo,
- joinFunction,
- windowBounds.getLeftTimeIdx(),
- windowBounds.getRightTimeIdx());
- // TODO: add async version rowJoinFunc to use
AsyncKeyedCoProcessOperator
+ TwoInputStreamOperator<RowData, RowData, RowData> operator;
+ if (config.get(ExecutionConfigOptions.TABLE_EXEC_ASYNC_STATE_ENABLED))
{
+ AsyncRowAsyncTimeIntervalJoin rowJoinFunc =
+ new AsyncRowAsyncTimeIntervalJoin(
+ joinSpec.getJoinType(),
+ windowBounds.getLeftLowerBound(),
+ windowBounds.getLeftUpperBound(),
+ 0L, // allowedLateness
Review Comment:
should we not pass allowedLateness through ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
