Github user wuchong commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3039#discussion_r93759055
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/schema/TableSourceTable.scala
 ---
    @@ -25,6 +25,6 @@ import org.apache.flink.types.Row
     /** Table which defines an external table via a [[TableSource]] */
     class TableSourceTable(val tableSource: TableSource[_])
       extends FlinkTable[Row](
    --- End diff --
    
    I think it's not necessary to declare the return type is `Row`. 
`TableSource` could return Pojo in the future.
    
    So it should be declared like `DataSetTable` and `DataStreamTable`, such 
as: 
    
    ```scala
    class TableSourceTable[T](val tableSource: TableSource[T])
      extends FlinkTable[T](
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to